fix: safely handle Content-Disposition download filenames - #237
Open
ryanduguid wants to merge 7 commits into
Open
fix: safely handle Content-Disposition download filenames#237ryanduguid wants to merge 7 commits into
ryanduguid wants to merge 7 commits into
Conversation
…t-disposition-filenames
ryanduguid
marked this pull request as draft
August 12, 2026 17:49
ryanduguid
marked this pull request as ready for review
August 18, 2026 15:06
os.link is not in os.supports_follow_symlinks on Windows and the source is
always a fresh mkstemp regular file, so follow_symlinks=False never had an
effect. On a build that honours the documented contract it raises
NotImplementedError, a RuntimeError subclass that escapes the except OSError
and breaks every file download. Drop the argument; destination symlinks are
still refused because os.link fails when the destination exists.
Cover the whole Windows reserved-name set with literal names rather than
deriving them from the implementation constant, so narrowing the COM/LPT
range fails the suite instead of passing silently. Add cases for names that
sanitise down to an empty string, which only the ("", ".", "..") guard
rejects and which would otherwise resolve to the download directory itself.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Content-Dispositionfilenames with the standard-library MIME parserThis SDK contains generated client code. The same hardening should also be carried into Xero's customised Python API-client template before the next regeneration.
Validation
datetime.timestamp()pre-epoch failure fixed independently by fix: serialize epoch datetimes on Windows #242 remainsgit diff --check